Repository navigation
feat: pick Android emulator camera source; fix laggy headless streams - #75
Merged
Merged
Conversation
Emulator -camera-back/-camera-front from the app's device menu (Camera, next boot), CLI --camera-back/--camera-front, and MCP start_device cameraBack/cameraFront. simutil_adb 1.4.0 adds emulatorCameraArgs and AndroidDeviceService.listWebcams.
Add a camera button on a running Android emulator's stream tile that picks the back/front source and restarts the emulator. Ask for macOS Camera access before booting with a host webcam (falls back to the emulator's own cameras when denied), and reject one webcam feeding both cameras, which crashes the emulator's camera app.
Headless emulators (-no-window) fall back to software rendering (lavapipe) under `-gpu auto`, so scrcpy streamed at ~5 fps. Launch them with `-gpu host` unless the caller passes its own `-gpu`: ~55 fps. adb lists an emulator before Android finishes booting, so a stream opened at boot started scrcpy-server too early and it crashed with a null ActivityManager. ScrcpySession now waits for sys.boot_completed (up to 3 min) before starting the server.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 25
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android emulator camera source (CLI, TUI, desktop app, MCP)
webcam<N>), an image, a video file,virtualscene,emulatedornone.simutil launch --camera-back/--camera-front. Desktop app: device menu → Camera (used from the next boot), or the new camera button on a running emulator's stream tile (restarts it). MCP:start_devicetakescameraBack/cameraFront.simutil_adb:emulatorCameraArgs,AndroidDeviceService.listWebcams().Headless emulator stream fixes
-no-window) fell back to software rendering (lavapipe) under-gpu auto, so the scrcpy stream ran at ~5 fps. They now launch with-gpu hostunless the caller passes its own-gpu.scrcpy server did not start ... NullPointerException ... ActivityManager.getContentProviderExternal: adb lists an emulator before Android finishes booting.ScrcpySessionnow waits forsys.boot_completed(up to 3 min) before starting the server.Not tested:
-gpu hoston Linux / Windows hosts without a usable GPU (VMs, RDP); passing-gpu swiftshader_indirectoverrides it.Type of Change
Summary by CodeRabbit