fix(nexusmutual): capital_pool_mcr stale since 2025-10-30 (MCR merged into new Pool contract) - #9962
Open
rmelbardis wants to merge 1 commit into
Open
fix(nexusmutual): capital_pool_mcr stale since 2025-10-30 (MCR merged into new Pool contract)#9962rmelbardis wants to merge 1 commit into
rmelbardis wants to merge 1 commit into
Conversation
… into new Pool contract)
PR SummaryLow Risk Overview Adds a third Reviewed by Cursor Bugbot for commit cd3364d. Configure here. |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
rmelbardis
marked this pull request as ready for review
August 21, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix:
nexusmutual_ethereum.capital_pool_mcrhas served a stale MCR value since 2025-10-30.In Nexus Mutual's 2025-10-30 release, the standalone MCR contract (
0xcafea92739e411a4d95bbc2275ca61de6993c9a7) was retired and MCR logic moved into the new Pool proxy. The event signature is unchanged (topic00x6e87c25e322c4ad68faf7916d0788baaf714d806fe887a84ee4b84ad9666f686) and is already decoded asnexusmutual_ethereum.Pool_evt_MCRUpdated, but the spell only reads the retired contract's tables, so its forward-fill repeats the 2025-10-30 value indefinitely.Expected value (block explorer): https://etherscan.io/address/0xcafea91714e55756c125b509274ede9bc91697cb#events — latest
MCRUpdated(2026-08-20) hasmcr≈ 10,176.8 ETH.Incorrect value (Dune):
select max(block_date), max_by(mcr_eth_total, block_date) from nexusmutual_ethereum.capital_pool_mcr→ stuck at 7,556.6 ETH (~26% understated).Scale: every row since 2025-10-30 (~300 days); feeds the MCR and MCR% charts on the Nexus Mutual Capital Pool dashboard.
Fix: add
Pool_evt_MCRUpdatedas a third union branch inmcr_events(identical column names) and register the source.