Skip to content

feat(prices): add PENDLE to base, bnb, and sonic token lists - #9884

Open
mkzung wants to merge 1 commit into
duneanalytics:mainfrom
mkzung:feat/pendle-prices-base-bnb-sonic
Open

feat(prices): add PENDLE to base, bnb, and sonic token lists#9884
mkzung wants to merge 1 commit into
duneanalytics:mainfrom
mkzung:feat/pendle-prices-base-bnb-sonic

Conversation

@mkzung

@mkzung mkzung commented Jul 9, 2026

Copy link
Copy Markdown

Adds the PENDLE token to the Base, BNB and Sonic prices token lists.

PENDLE trades on all three chains but had no USD price in Spellbook. The
coinpaprika id pendle-pendle already prices PENDLE on Ethereum, Arbitrum,
Mantle and Optimism, so this reuses the existing mapping to close a data
gap. No new coinpaprika id, no schema change, data rows only.

Verified each contract on-chain via eth_call (symbol() == PENDLE, decimals() == 18):

CoinPaprika: https://coinpaprika.com/coin/pendle-pendle

Precedent: PENDLE was added to Optimism the same way in #6752.

@github-actions github-actions Bot added the WIP work in progress label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions Bot added the dbt: tokens covers the Tokens dbt subproject label Jul 9, 2026
@mkzung

mkzung commented Jul 9, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@mkzung
mkzung marked this pull request as ready for review July 9, 2026 22:19
github-actions Bot added a commit that referenced this pull request Jul 9, 2026
@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Static data-only additions to token allowlists; main risk is a wrong contract address mispricing PENDLE on those chains, mitigated by on-chain verification noted in the PR.

Overview
Adds PENDLE to the static CoinPaprika-backed token price maps for Base, BNB, and Sonic, using the existing pendle-pendle id and chain-specific contract addresses (18 decimals each).

This follows the same pattern as PENDLE on Ethereum, Arbitrum, Mantle, and Optimism: no new price feed id or schema change—only new rows in prices_*_tokens so Spellbook can attach USD prices where the token was missing.

Reviewed by Cursor Bugbot for commit 596de0c. Configure here.

@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jul 9, 2026
@mkzung

mkzung commented Aug 4, 2026

Copy link
Copy Markdown
Author

Gentle bump on this one. It has been open a month with all checks green, while token PRs opened either side of it (#9879, #9888) merged within days, so I think it has just been missed rather than held.

The three addresses check out against an independent registry, all 18 decimals: Base 0xa99f6e6785da0f5d6fb42495fe424bce029eeb3e, BNB 0xb3ed0a426155b79b898849803e3b36552f7ed507, Sonic 0xf1ef7d2d4c0c881cd634481e0586ed5d2871a74b. None of the three files carries a PENDLE row today, so there is nothing to duplicate, and the pendle-pendle id is the one already used for PENDLE on Ethereum, Arbitrum, Mantle and Optimism.

Happy to rebase if it has gone stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbt: tokens covers the Tokens dbt subproject ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant