Skip to content

Fix admin auth, cap admin list, and remove unused dispute counter initialization for the reported issues. #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dultimateade merged 2 commits into from
Oct 22, 2026
Merged

Fix admin auth, cap admin list, and remove unused dispute counter initialization for the reported issues. #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084754a
Fix admin auth, cap admin list, and remove unused dispute counter ini…
joelatabs Oct 22, 2026
d33875d
Merge branch 'main' into fix/issue-218-221-pr
dultimateade Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions contracts/analytics/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,31 @@ impl Analytics {
/// @param env The contract environment.
/// @param admin The address that will own the contract and manage authorized reporters.
pub fn initialize(env: Env, admin: Address) -> Result<(), ContractError> {
// Check if already initialized
if env.storage().persistent().has(&DataKey::Admin) {
admin.require_auth();
if env.storage().instance().has(&DataKey::Initialized) {
return Err(ContractError::AlreadyInitialized);
}

// Store the admin address
env.storage().persistent().set(&DataKey::Admin, &admin);
env.storage().instance().set(&DataKey::Initialized, &true);
env.storage().instance().set(&DataKey::Admin, &admin);
env.storage().instance().set(&DataKey::Paused, &false);
env.storage()
.instance()
.set(&DataKey::MaxCapacity, &storage::DEFAULT_MAX_CAPACITY);

env.events().publish(
(symbol_short!("analytics"), symbol_short!("init")),
admin,
);

Ok(())
}

/// Sets a new admin for the contract. Requires authorization from current admin.
pub fn set_admin(env: Env, caller: Address, new_admin: Address) -> Result<(), ContractError> {
caller.require_auth();
Self::assert_admin(&env, &caller)?;
env.storage().instance().set(&DataKey::Admin, &new_admin);

// Initialize empty set of authorized reporters
let reporters: Vec<Address> = Vec::new(&env);
Expand Down Expand Up @@ -285,3 +303,4 @@ impl Analytics {
sorted.get(idx).unwrap_or(0)
}
}

Loading
Loading