Repository navigation
fix: pass operation to serverFetchOptions and graphqlEndpoint in doGraphqlRequest - #83
Merged
dulnan merged 1 commit intoApr 9, 2026
Conversation
…quest In doGraphqlRequest, the `operation` variable was correctly extracted from `body.operation` (line 46) but `null` was passed to both `getEndpoint()` and `getFetchOptions()` instead of the actual value. This meant that `serverFetchOptions` and `graphqlEndpoint` callbacks always received `null` as the `operation` parameter, making it impossible to distinguish between queries and mutations in these hooks. The bug was introduced in commit 3c03c29 (initial file creation) where all four callsites used `null`. Commit 648d472 fixed `onServerResponse` and `onServerError` but missed `getEndpoint` and `getFetchOptions`. Note: the upload handler (upload.ts) was not affected — it calls getEndpoint/getFetchOptions directly and already passes `operation` correctly. Also fixes a minor inconsistency where `getFetchOptions` used `body.operationName || null` instead of the already-extracted `operationName` local variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doGraphqlRequestextractsoperationfrombody.operationbut passesnullto bothgetEndpoint()andgetFetchOptions(). This meansserverFetchOptionsandgraphqlEndpointcallbacks always receivenullas theoperationparameter.The bug was introduced in 3c03c29 where all callsites used
null. Commit 648d472 ("pass operation and operationName to onServerResponse") fixedonServerResponseandonServerErrorbut missed the other two.Note: the upload handler (
upload.ts) is not affected — it calls these functions directly and already passesoperationcorrectly.Changes
operationinstead ofnulltogetEndpoint()andgetFetchOptions()indoGraphqlRequestoperationNamelocal variable instead ofbody.operationName || nullin thegetFetchOptionscalloperationis correctly forwarded for both queries and mutations