Repository navigation
fix(monitor): make alert webhook optional and log-only - #224
Open
collinsezedike wants to merge 1 commit into
Open
collinsezedike wants to merge 1 commit into
collinsezedike wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled monitor no longer fails when
ALERT_WEBHOOK_URLis unset. With no webhook configured it polls, logs every event, emits a warning, and exits cleanly, so the every-five-minute red runs onmainstop while the service still does useful work. Configuring the secret later enables alert delivery with no code change.This affects only
packages/tholos-monitorand its workflow. No contract or SDK changes.Test plan
pnpm lint,pnpm build, andpnpm testpass inpackages/tholos-monitor(25 tests)node dist/main.jsagainst the canonical testnet v1 contract with no webhook; it polled from ledger 5318774 and finished cleanlyscripts/testnet-smoke.share not applicable to this change