Bump Scrutor to 7.0.0; skip claude-review for dependabot PRs - #27
Merged
Conversation
Scrutor 7 replaces the conflicted dependabot PR #20; the only usage is the basic assembly scan in Program.cs, unaffected by the major bump. All 74 tests pass. The claude-review job fails on every dependabot PR because dependabot-triggered runs only receive Dependabot secrets, so CLAUDE_CODE_OAUTH_TOKEN is empty. Skip the job for the bot - version bumps don't need an AI review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces dependabot PRs #20 (conflicting branch) and the failing-by-design claude-review runs on bot PRs:
services.Scan(...FromAssemblyOf<IPluginNodes>()...)insrc/Program.cs; Scrutor 7's breaking changes don't touch it.claude-reviewfor dependabot — dependabot-triggeredpull_requestruns only get Dependabot secrets, sosecrets.CLAUDE_CODE_OAUTH_TOKENis empty and the job fails in seconds on every bot PR.Not included: the OPCFoundation 1.5.376.244 → 1.5.378.156 bump (dependabot #19). That update changes
ICertificateStore(newEnumerateAsync/AddAsync/AddRejectedAsyncmembers), which breaksFlatDirectoryCertificateStore— and #19's green CI never caught it because it only bumped the Debug-config packages while CI builds Release. Needs its own PR with the interface implemented across all three csproj pins (src, browser, tests).Test plan
dotnet build druopc.slnxclean in both Release and Debug.dotnet test tests -c Release: 74/74 passed.