SUI: new epoch bound, drop state bound and leave block - #394
Merged
Merged
Conversation
KirillPamPam
force-pushed
the
sui_bound
branch
from
October 1, 2026 07:40
039993f to
5daba33
Compare
EugeneDrpc
reviewed
Oct 1, 2026
| if lowest := serviceInfo.GetLowestAvailableCheckpoint(); lowest > 0 { | ||
| bounds = append(bounds, protocol.NewLowerBoundDataNow(int64(lowest), protocol.BlockBound)) //nolint:gosec // checkpoint sequences are far below int64 max | ||
| lowest := serviceInfo.GetLowestAvailableCheckpoint() | ||
| if lowest == 0 { |
Contributor
There was a problem hiding this comment.
Hmm, what does an unpruned node actually report here, an explicit 0 or no field? If it's 0, we'd never publish a block bound, and with #3006 dproxy would treat that node as SoftUnavailable on every Sui call. Maybe publish 1 when it's explicitly 0, and skip only when the field is absent?
Collaborator
Author
There was a problem hiding this comment.
Totally agree, fixed
EugeneDrpc
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.