Recover stuck multistream head and cap lower bound retries - #905
Merged
Merged
Conversation
KirillPamPam
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Linea (linea-besu), Dshackle stops updating the multistream head until restart:
These are two independent bugs.
1. Multistream head freezes
PriorityForkChoiceaccepts onlyheight > currentand never resets.AbstractHead.onNoHeadUpdates()was a no-op. If an upstream height ever drops below the max the multistream has seen (node rollback/resync, or one bogus high block), the head stays frozen until the node passes the old max.Fix:
ForkChoice.reset()(default no-op).PriorityForkChoice.reset()lets the next unseen block through regardless of height, without clearing the current head.AbstractHead.onNoHeadUpdates()callsforkChoice.reset()(after 60s without updates).2. PROOF lower bound retries forever
Besu returns
World state unavailableforeth_getProofon pruned state. It was not inNO_PROOF_ERRORS, andRecursiveLowerBound.retrySpecusedLong.MAX_VALUEretries, so the detector never settled.Fix: add
World state unavailable/Worldstate unavailabletoNO_PROOF_ERRORS; cap retries at 30 (a block then counts as "no data"); warn once on the last retry; fix swapped log arguments (type, upstreamId, block).Supersedes #904 (it covers only one spelling and keeps unlimited retries).
Build
grpcVersion1.49.2 → 1.81.0 (matches grpc runtime; 1.49.2 plugin is x86_64-only and fails on arm64 without Rosetta).Tests
PriorityForkChoiceSpec: lower block accepted once afterreset().RecursiveLowerBoundServiceTest: PROOF bound settles for both Besu messages and for an unknown error (fails on old code)../gradlew check: all pass exceptIntegrationTest(needs Docker, unrelated).