fix: prevent crash when reading user IDs from secure storage#460
Open
anthonioez wants to merge 1 commit into
Open
fix: prevent crash when reading user IDs from secure storage#460anthonioez wants to merge 1 commit into
anthonioez wants to merge 1 commit into
Conversation
Safely unwrap the "acct" keychain attribute using `compactMap` and `as? String` to prevent fatal errors when the value is missing or not a String.
|
Hi @anthonioez, Thanks for opening this PR and for the proposed fix here. Would you be able to share reproduction steps or a bit more context on when the fatal error happens when reading the user IDs from secure storage? In particular, it would be helpful to know what conditions lead to the acct keychain attribute being missing or not a String. Those details will help us better understand the underlying issue and validate the fix. Thanks again for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safely unwrap the "acct" keychain attribute using
compactMapandas? Stringto prevent fatal errors when the value is missing or not a String.