Skip to content

Remove unused variable#438

Open
bagage wants to merge 2 commits into
drolbr:minor_issuesfrom
bagage:minor_issues
Open

Remove unused variable#438
bagage wants to merge 2 commits into
drolbr:minor_issuesfrom
bagage:minor_issues

Conversation

@bagage

@bagage bagage commented Sep 22, 2017

Copy link
Copy Markdown

No description provided.

@mmd-osm

mmd-osm commented Sep 22, 2017

Copy link
Copy Markdown
Contributor

While you're at it: there's another issue here: 4cc57fb#comments

@bagage

bagage commented Sep 23, 2017

Copy link
Copy Markdown
Author

Readded @mmd-osm.

@mmd-osm

mmd-osm commented Sep 23, 2017

Copy link
Copy Markdown
Contributor

That's not exactly what I meant, I should read std::string result = "(id:"; like it already was here:

std::string result = "(id:";

Or even better would be something like:

std::string result = (refs.size() > 1 ? "(id:" : "(");

@bagage

bagage commented Sep 23, 2017

Copy link
Copy Markdown
Author

@mmd-osm Does it sound better now?

@bagage bagage closed this Sep 23, 2017
@bagage bagage deleted the minor_issues branch September 23, 2017 13:09
@bagage bagage restored the minor_issues branch September 23, 2017 13:09
@bagage bagage reopened this Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants