Add crisp start button icon rendering option#1405
Open
rmnmjw wants to merge 1 commit into
Open
Conversation
The classic-theme start button icons (start9x, startvistaclassic, startxpclassic, startxpblue) are small bitmaps shown at their native size. At integer display scales (e.g. 200%) WPF's default scaling filter blurred them and muddied their colors. Render them with nearest-neighbor scaling so they stay sharp, controlled by a "Crisp start button icon" checkbox on the Advanced tab (on by default). The StartIcon style sets BitmapScalingMode=NearestNeighbor via a trigger bound to the setting, so it can be disabled on fractional scales where nearest-neighbor can look uneven. Add localized labels for all bundled languages, each with an access key that is unique within that language's Advanced tab.
|
Download the artifacts for this pull request: |
Owner
|
I think this makes more sense as part of the theme rather than as a user preference (i.e. the theme should "just do the right thing" here). You might need to add a property to the taskbar window that can tell the theme whether the taskbar is integer scaled (i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my mission to add more crispy graphics for scaled UI, here is the latest change.
The classic-theme start button icons (start9x, startvistaclassic, startxpclassic, startxpblue) are small bitmaps shown at their native size. At integer display scales (e.g. 200%) WPF's default scaling filter blurred them and muddied their colors.
Render them with nearest-neighbor scaling so they stay sharp, controlled by a "Crisp start button icon" checkbox on the Advanced tab (on by default). The StartIcon style sets BitmapScalingMode=NearestNeighbor via a trigger bound to the setting, so it can be disabled on fractional scales where nearest-neighbor can look uneven.
Add localized labels for all bundled languages, each with an access key that is unique within that language's Advanced tab.