Skip to content

fix(client): Apply strikethrough styling to cut stage directions in cue editor - #747

Merged
Tim020 merged 1 commit into
devfrom
fix/issue-691-cut-stage-directions
Dec 1, 2025
Merged

fix(client): Apply strikethrough styling to cut stage directions in cue editor#747
Tim020 merged 1 commit into
devfrom
fix/issue-691-cut-stage-directions

Conversation

@Tim020

@Tim020 Tim020 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Fixes #691

Problem

Cut stage directions were not displaying with strikethrough styling in the cue editor view, while regular cut line parts were correctly styled with strikethrough.

Root Cause

The cut-line-part CSS class (which applies text-decoration: line-through) was only being applied to regular line parts, not to stage directions. The rendering logic had two separate code paths:

  1. Regular line parts (lines 67-89): ✅ Applied cut-line-part class correctly
  2. Stage directions (lines 42-65): ❌ Missing cut-line-part class

Solution

Applied the existing cut-line-part CSS class to stage directions when they are cut, using the same logic already used for regular line parts:

:class="{'cut-line-part': linePartCuts.indexOf(line.line_parts[0].id) !== -1}"

Since stage directions have only one line part at index 0, we check if that line part's ID is in the linePartCuts array.

Changes

File: client/src/vue_components/show/config/cues/ScriptLineCueEditor.vue

  1. Main cue editor view (line 49): Added conditional class binding to stage direction element
  2. Modal dialog view (line 163): Added same conditional class binding to modal's stage direction display

Both locations now consistently apply strikethrough styling to cut stage directions.

Testing

Manual Testing Required

Since this is a UI change, manual testing is needed:

  1. Navigate to the cue editor page
  2. Create or find a stage direction
  3. Mark the stage direction as "cut"
  4. Expected: Stage direction should display with strikethrough styling
  5. Before fix: Stage direction displayed normally without strikethrough
  6. After fix: Stage direction displays with strikethrough

Visual Comparison

Before:

  • Regular cut lines: strikethrough
  • Cut stage directions: no strikethrough

After:

  • Regular cut lines: strikethrough
  • Cut stage directions: strikethrough

Code Quality

  • ✅ No new dependencies
  • ✅ Uses existing CSS class (.cut-line-part)
  • ✅ Consistent with existing code patterns for regular line parts
  • ✅ Applied in both main view and modal for consistency

Impact

  • Low risk: Only affects visual styling, no logic changes
  • Scope: Only affects cue editor view for stage directions
  • Backwards compatible: No API or data model changes

🤖 Generated with Claude Code

…ue editor

Fixes #691

Cut stage directions were not showing with strikethrough styling in the
cue editor view, while regular cut line parts were correctly styled.

Changes:
- Applied the existing 'cut-line-part' CSS class to stage directions when
  they are cut (checked via linePartCuts array)
- Updated both the main cue editor view and the modal dialog view to
  consistently apply the styling

The fix uses the same logic already used for regular line parts:
:class="{'cut-line-part': linePartCuts.indexOf(line.line_parts[0].id) !== -1}"

Since stage directions have only one line part (index 0), we check if
that line part's ID is in the linePartCuts array and apply the
strikethrough class accordingly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added client Pull requests changing front end code xsmall-diff labels Dec 1, 2025
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown

Test Results

31 tests   31 ✅  8s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 7cfa117.

@Tim020
Tim020 merged commit 2f3265a into dev Dec 1, 2025
12 checks passed
@Tim020
Tim020 deleted the fix/issue-691-cut-stage-directions branch December 1, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests changing front end code xsmall-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant