fix(client): Apply strikethrough styling to cut stage directions in cue editor - #747
Merged
Merged
Conversation
…ue editor Fixes #691 Cut stage directions were not showing with strikethrough styling in the cue editor view, while regular cut line parts were correctly styled. Changes: - Applied the existing 'cut-line-part' CSS class to stage directions when they are cut (checked via linePartCuts array) - Updated both the main cue editor view and the modal dialog view to consistently apply the styling The fix uses the same logic already used for regular line parts: :class="{'cut-line-part': linePartCuts.indexOf(line.line_parts[0].id) !== -1}" Since stage directions have only one line part (index 0), we check if that line part's ID is in the linePartCuts array and apply the strikethrough class accordingly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Test Results31 tests 31 ✅ 8s ⏱️ Results for commit 7cfa117. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #691
Problem
Cut stage directions were not displaying with strikethrough styling in the cue editor view, while regular cut line parts were correctly styled with strikethrough.
Root Cause
The
cut-line-partCSS class (which appliestext-decoration: line-through) was only being applied to regular line parts, not to stage directions. The rendering logic had two separate code paths:cut-line-partclass correctlycut-line-partclassSolution
Applied the existing
cut-line-partCSS class to stage directions when they are cut, using the same logic already used for regular line parts::class="{'cut-line-part': linePartCuts.indexOf(line.line_parts[0].id) !== -1}"Since stage directions have only one line part at index 0, we check if that line part's ID is in the
linePartCutsarray.Changes
File:
client/src/vue_components/show/config/cues/ScriptLineCueEditor.vueBoth locations now consistently apply strikethrough styling to cut stage directions.
Testing
Manual Testing Required
Since this is a UI change, manual testing is needed:
Visual Comparison
Before:
strikethrough✅After:
strikethrough✅strikethrough✅Code Quality
.cut-line-part)Impact
🤖 Generated with Claude Code