Bump electron devDependencies (@types/node, typescript-eslint) - #1383
Conversation
Recreated locally from dependabot PR #1379 (which targeted 26.5.1) since the lockfile must be regenerated on macOS, not copied from the Linux-based dependabot runner. 26.6.1 is now the latest patch satisfying the same ^26.5.1 caret range. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rom 8.69.0 to 8.70.0 in /electron Recreated locally from dependabot PRs #1376 and #1375. Combined into one commit since these two packages must stay version-matched. Lockfile regenerated on macOS rather than copied from the Linux-based dependabot runner. No new lint violations from the bump. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
client
Client Test Results132 tests 132 ✅ 0s ⏱️ Results for commit 2a6605d. ♻️ This comment has been updated with latest results. |
Client V3 Test Results39 tests 39 ✅ 0s ⏱️ Results for commit 2a6605d. ♻️ This comment has been updated with latest results. |
Playwright E2E Results (firefox)221 tests 221 ✅ 2m 8s ⏱️ Results for commit 2a6605d. ♻️ This comment has been updated with latest results. |
Python Test Results 1 files 1 suites 2m 24s ⏱️ Results for commit 2a6605d. ♻️ This comment has been updated with latest results. |
Playwright E2E Results (chromium)221 tests 221 ✅ 2m 16s ⏱️ Results for commit 2a6605d. ♻️ This comment has been updated with latest results. |
CI failed on this branch with `npm error Missing: encoding@0.1.13 from lock file` / `Missing: iconv-lite@0.6.3 from lock file` — the local macOS `npm install <pkg>` regeneration in the prior two commits silently dropped minipass-fetch's optional `encoding` dependency (and its nested iconv-lite@0.6.3) from the lockfile, even though `npm ci` installs it fine and it's present on `dev`. Restored the two entries verbatim from `dev`'s lockfile. `npm ci`, typecheck and ci-lint all pass clean with this fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
1 participant
Summary
Recreates the changes from dependabot PRs #1379, #1376, #1375 by regenerating
electron/package-lock.jsonlocally on macOS instead of copying the Linux-generated lockfile from the dependabot runner (see repo convention for client-side dependency PRs).@types/node: 26.4.1 → 26.6.1 (dependabot targeted 26.5.1; 26.6.1 is now latest in the same^26.5.1range)@typescript-eslint/eslint-plugin: 8.69.0 → 8.70.0@typescript-eslint/parser: 8.69.0 → 8.70.0All devDependencies.
npm run typecheckandnpm run ci-lintpass clean with no new violations.Closes the following dependabot PRs once merged: #1379, #1376, #1375
Test plan
npm run typecheckpassesnpm run ci-lintpasses (prettier + eslint)npm ci+npm install <pkg>@<version>on macOS🤖 Generated with Claude Code