Fix cut stage directions not showing strikethrough in cue editor - #1226
Merged
Conversation
Users previously had to delete and re-add an entire line to remove a single part. A remove button now appears in the character row of each ScriptLinePart when the line has more than one part, and disappears when only one part remains. Implemented in both client-v3 and client with E2E coverage added to the script spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace BFormGroup label=" " wrapper with align-self-end mb-3 on the column directly, which is the standard Bootstrap way to align a button with adjacent form controls without adding a dummy label. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Stage directions in the cue editor were missing strikethrough styling when cut, because the render path used the base sdStyling computed (no cut check). Replace it with sdStylingWithCuts, which appends line-through to the existing text-decoration-line value when the stage direction's first part ID is in cuts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
client
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 7f5b06c. ♻️ This comment has been updated with latest results. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 7f5b06c. ♻️ This comment has been updated with latest results. |
github-actions
Bot
added
small-diff
Tim020
enabled auto-merge (squash)
June 20, 2026 20:27
Python Test Results 1 files 1 suites 1m 59s ⏱️ Results for commit 7f5b06c. |
Playwright E2E Results (chromium)188 tests 188 ✅ 1m 58s ⏱️ Results for commit 7f5b06c. |
Playwright E2E Results (firefox)188 tests 188 ✅ 1m 57s ⏱️ Results for commit 7f5b06c. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScriptLineCueEditor.vuebound stage direction styling tosdStyling(base style only), never consulting thecutspropsdStylingwith a newsdStylingWithCutscomputed that appendsline-throughtotext-decoration-linewhen the stage direction's first part ID is incuts— matching the existingstageDirectionStylingWithCutslogic inScriptLineViewer.vueTest plan
npm run typecheckpassesnpm run ci-lintpasses🤖 Generated with Claude Code