Add ability to delete individual line parts from the script editor - #1225

Merged

Tim020 merged 2 commits into

devfrom

feature/delete-line-parts

Jun 20, 2026

Tim020 commented Jun 19, 2026

Contributor

Summary

Adds a small outline-danger remove button in the character/character group row of each ScriptLinePart, visible only when the line has more than one part
Button disappears automatically when a single part remains, preventing accidental full-line deletion
On removal, remaining parts are re-sequenced (part_index) so the existing PATCH endpoint correctly migrates cuts and cue associations — no backend changes required
Implemented in both client-v3/ (Vue 3, using IMdiMinusBox) and client/ (Vue 2, using b-icon-dash-square-fill)

Test plan

Open show config → Script tab, enter edit mode, add a DIALOGUE line with 1 part — confirm no remove button is visible
Click + to add a second part — confirm remove buttons appear on both parts
Click a remove button — confirm it reduces to 1 part and the remove buttons disappear
Fill in the remaining part, save — confirm the saved line appears correctly in the viewer
Repeat the above in the legacy UI (/ui-old/)
4 new Playwright E2E tests added to 10-show-config-script.spec.ts — all 188 tests pass

🤖 Generated with Claude Code


          Add ability to delete individual line parts from the script editor

d72f7a8

Users previously had to delete and re-add an entire line to remove a
single part. A remove button now appears in the character row of each
ScriptLinePart when the line has more than one part, and disappears
when only one part remains. Implemented in both client-v3 and client
with E2E coverage added to the script spec.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Tim020 added the claude label

github-actions Bot added client medium-diff client-v3 labels

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Client V3 Test Results

23 tests 23 ✅ 0s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 19c3dff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Client Test Results

128 tests 128 ✅ 0s ⏱️
6 suites 0 💤
1 files 0 ❌

Results for commit 19c3dff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Python Test Results

1 files 1 suites 2m 6s ⏱️
662 tests 662 ✅ 0 💤 0 ❌
667 runs 667 ✅ 0 💤 0 ❌

Results for commit 19c3dff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Playwright E2E Results (firefox)

188 tests 188 ✅ 1m 58s ⏱️
14 suites 0 💤
1 files 0 ❌

Results for commit 19c3dff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Playwright E2E Results (chromium)

188 tests 188 ✅ 1m 59s ⏱️
14 suites 0 💤
1 files 0 ❌

Results for commit 19c3dff.

♻️ This comment has been updated with latest results.


          Fix vertical alignment of remove line part button

19c3dff

Replace BFormGroup label=" " wrapper with align-self-end mb-3 on the
column directly, which is the standard Bootstrap way to align a button
with adjacent form controls without adding a dummy label.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Tim020 enabled auto-merge (squash)

June 20, 2026 00:01

Tim020 merged commit efa6c4f into dev

34 of 35 checks passed

Tim020 deleted the feature/delete-line-parts branch

June 20, 2026 00:03

sonarqubecloud Bot commented Jun 20, 2026

Quality Gate failed

Failed conditions
11.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude client client-v3 medium-diff