Skip to content

Add bulk character/group assignment to script bulk edit mode - #1224

Merged
Tim020 merged 2 commits into
devfrom
feature/bulk-edit-character-assignment
Jun 19, 2026
Merged

Add bulk character/group assignment to script bulk edit mode#1224
Tim020 merged 2 commits into
devfrom
feature/bulk-edit-character-assignment

Conversation

@Tim020

@Tim020 Tim020 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extends BulkActSceneModal into a new BulkEditModal with two always-visible sections: Act / Scene and Character Assignment
  • Users can select a target part index (1–4) and assign a character or character group to that part across the entire bulk line range
  • Applied changes are derived from filled values — no checkboxes needed; each section is independently applied if its values are non-null
  • Lines with fewer parts than the selected part index are silently skipped
  • Setting a character clears the character group on that part and vice versa
  • Implemented with feature parity in both client-v3/ (Vue 3) and client/ (Vue 2 legacy)

Test plan

  • client-v3 TypeScript typecheck passes (npm run typecheck)
  • client-v3 lint passes (npm run ci-lint)
  • client-v3 unit tests pass (npm run test:run)
  • client TypeScript typecheck passes
  • client lint passes
  • client unit tests pass
  • Backend ruff lint passes
  • Full Playwright E2E suite passes (184/184 tests) — 4 new bulk edit tests added to 10-show-config-script.spec.ts
  • Manual test in dev browser: enter bulk edit mode → verify modal shows both sections → test act/scene only, character only, and both together

🤖 Generated with Claude Code

Extends the existing bulk act/scene modal into a full BulkEditModal
supporting character and character group assignment across a line range.
Users can now select a target part index (1–4) and assign a character
or character group to that part for all lines in the bulk range; lines
without the targeted part are silently skipped. Both act/scene and
character assignment sections are always visible and independently
applied based on whether their values are filled in.

Implemented in both client-v3 and client (Vue 2 legacy) with parity.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Tim020 Tim020 added the claude Issues created by Claude label Jun 19, 2026
@github-actions github-actions Bot added client Pull requests changing front end code large-diff client-v3 labels Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Client V3 Test Results

23 tests  ±0   23 ✅ ±0   0s ⏱️ ±0s
 2 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e39762c. ± Comparison against base commit 0f54353.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Client Test Results

128 tests  ±0   128 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e39762c. ± Comparison against base commit 0f54353.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Python Test Results

  1 files  ±0    1 suites  ±0   1m 58s ⏱️ -2s
662 tests ±0  662 ✅ ±0  0 💤 ±0  0 ❌ ±0 
667 runs  ±0  667 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e39762c. ± Comparison against base commit 0f54353.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Playwright E2E Results (firefox)

184 tests  +4   184 ✅ +4   1m 54s ⏱️ +2s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e39762c. ± Comparison against base commit 0f54353.

♻️ This comment has been updated with latest results.

@Tim020
Tim020 enabled auto-merge (squash) June 19, 2026 23:26
@github-actions

Copy link
Copy Markdown

Playwright E2E Results (chromium)

184 tests  +4   184 ✅ +4   1m 57s ⏱️ -1s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e39762c. ± Comparison against base commit 0f54353.

@Tim020
Tim020 merged commit 609e527 into dev Jun 19, 2026
34 of 35 checks passed
@Tim020
Tim020 deleted the feature/bulk-edit-character-assignment branch June 19, 2026 23:30
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude Issues created by Claude client Pull requests changing front end code client-v3 large-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant