Add V2 user API with REST semantics + edit user feature - #1159
Merged
Conversation
Introduces a versioned V2 API layer for user management, moving all existing controllers into an explicit `api/v1/` package and adding `api/v2/` with RESTful resource-oriented endpoints (GET/POST/PATCH/DELETE on `/api/v2/users`). Adds a new edit-user feature allowing admins to toggle user admin status, wired into both the Vue 2 and Vue 3 frontends with an extensible modal design (adding a new editable field requires only one line in EDITABLE_FIELDS and one form group in the template). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Moves all V1 controller tests from test/controllers/api/ into test/controllers/api/v1/ (with auth/ subpackage), mirroring the structure introduced when V1 controllers moved to controllers/api/v1/. The existing test/controllers/api/v2/ tests remain in place. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The V1 auth endpoints (login, logout, refresh-token, get current user) already used correct HTTP verbs and needed no refactoring. The V2 duplicates added no value and only increased maintenance burden. V2 remains exclusively for user management endpoints where V1 violated REST conventions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
documentation
…ints Password change and reset endpoints already used correct HTTP verbs in V1 (PATCH and POST respectively) and contained no logic changes in V2 — only a URL namespace move. Keeping only the V2 token controller where the POST /revoke → DELETE fix was a genuine REST improvement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controllers/api/intocontrollers/api/v1/(same package hierarchy, no behaviour change); test package mirrors the same structure undertest/controllers/api/v1/controllers/api/v2/users/that fix the non-REST verb problems in V1 (POST /auth/create→POST /api/v2/users,POST /auth/delete→DELETE /api/v2/users?id=); adds newPATCH /api/v2/users?id=for user editing;PATCH /api/v2/users/password,POST /api/v2/users/password/reset, andGET/POST/DELETE /api/v2/users/tokenalso migrated to the correct resource namespace/api/v1/auth/*EDITABLE_FIELDSon the backend and one<BFormGroup>in each modalclient/) and Vue 3 (client-v3/) store actions and components updated for V2 user endpoints; Edit button and modal added toConfigUsers.vuein both clientsdocs/pages/user_config.mdTest plan
pytest test/— 651/651 passruff check+ruff format --check— cleannpm run ci-lint+npm run typecheck+npm run test:run— 128/128 passnpm run ci-lint+npm run typecheck+npm run test:run— 23/23 passnpm run test:e2e— 163/163 pass (1 pre-existing flaky on live-show scroll-sync, unrelated to this change, passed on retry)🤖 Generated with Claude Code