Skip to content

Fix BVN modal props: no-footer / no-header-close (#1150) #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tim020 merged 1 commit into from
Jun 6, 2026
Merged

Fix BVN modal props: no-footer / no-header-close (#1150) #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client-v3/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@
ref="goToPageModal"
title="Go to Page"
size="sm"
:hide-header-close="changingPage"
:hide-footer="changingPage"
:no-header-close="changingPage"
:no-footer="changingPage"
:no-close-on-backdrop="changingPage"
:no-close-on-esc="changingPage"
@ok.prevent="goToLivePage"
Expand Down
8 changes: 4 additions & 4 deletions client-v3/src/components/config/ConfigUsers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,23 @@
</BCol>
</BRow>

<BModal ref="newUserModal" title="Add New User" size="md" hide-footer>
<BModal ref="newUserModal" title="Add New User" size="md" no-footer>
<CreateUser :is-first-admin="false" @created_user="handleUserCreated(newUserModal)" />
</BModal>

<BModal ref="newAdminModal" title="Add New Admin" size="md" hide-footer>
<BModal ref="newAdminModal" title="Add New Admin" size="md" no-footer>
<CreateUser
:is-first-admin="false"
:is-admin="true"
@created_user="handleUserCreated(newAdminModal)"
/>
</BModal>

<BModal ref="rbacModal" title="User RBAC Config" size="xl" hide-footer>
<BModal ref="rbacModal" title="User RBAC Config" size="xl" no-footer>
<ConfigRbac v-if="selectedUserId != null" :user-id="selectedUserId" />
</BModal>

<BModal ref="resetPasswordModal" title="Reset User Password" size="md" hide-footer>
<BModal ref="resetPasswordModal" title="Reset User Password" size="md" no-footer>
<ResetPassword
v-if="selectedUser"
:user-id="selectedUser.id"
Expand Down
4 changes: 2 additions & 2 deletions client-v3/src/components/show/config/cues/CueEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
ref="goToPageModal"
title="Go to Page"
size="sm"
:hide-header-close="changingPage"
:hide-footer="changingPage"
:no-header-close="changingPage"
:no-footer="changingPage"
:no-close-on-backdrop="changingPage"
:no-close-on-esc="changingPage"
:ok-disabled="pageV$.pageInputFormState.$invalid"
Expand Down
4 changes: 2 additions & 2 deletions client-v3/src/components/show/config/cues/JumpToCueModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
<BModal
ref="modal"
title="Jump to Cue"
:hide-header-close="searching || showResults"
:no-header-close="searching || showResults"
:no-close-on-backdrop="searching || showResults"
:no-close-on-esc="searching || showResults"
:ok-disabled="v$.cueSearchForm.$invalid"
:ok-title="showResults ? undefined : 'Search'"
:hide-footer="showResults"
:no-footer="showResults"
@ok.prevent="performCueSearch"
@hidden="resetCueSearch"
>
Expand Down
2 changes: 1 addition & 1 deletion client-v3/src/components/show/config/mics/MicAutoPopulateModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ref="modalRef"
size="xl"
title="Auto-Populate Microphones"
:hide-footer="true"
no-footer
@show="resetState"
@hidden="resetState"
>
Expand Down
9 changes: 5 additions & 4 deletions client-v3/src/components/show/config/script/ScriptEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,9 @@
ref="saveModal"
title="Saving Script"
size="md"
:hide-header-close="savingInProgress"
:hide-footer="savingInProgress"
:no-header-close="savingInProgress"
:no-footer="savingInProgress"
:ok-disabled="savingInProgress"
:no-close-on-backdrop="savingInProgress"
:no-close-on-esc="savingInProgress"
ok-only
Expand Down Expand Up @@ -174,8 +175,8 @@
ref="goToPageModal"
title="Go to Page"
size="sm"
:hide-header-close="changingPage"
:hide-footer="changingPage"
:no-header-close="changingPage"
:no-footer="changingPage"
:no-close-on-backdrop="changingPage"
:no-close-on-esc="changingPage"
@ok.prevent="goToPage"
Expand Down
2 changes: 1 addition & 1 deletion client-v3/src/components/show/config/sessions/SessionTagList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
ref="importTagModal"
title="Import Session Tag"
size="xl"
hide-footer
no-footer
@hide="resetImportState"
>
<div v-if="isLoadingImport" class="text-center">
Expand Down
2 changes: 1 addition & 1 deletion client-v3/src/views/show/config/ConfigCues.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
ref="importCueTypeModal"
title="Import Cue Type"
size="xl"
hide-footer
no-footer
@hide="resetImportState"
>
<div v-if="isLoadingImport" class="text-center">
Expand Down
Loading