Conversation
cyang31
marked this pull request as ready for review
July 12, 2023 21:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
The validation dataloader in pretrain step is not necessary. The current
samplerinpretraining_utils.pyline62 causes errors whenX_trainandX_validineval_setsdon't have the same size. See #499What kind of change does this PR introduce?
a bugfix
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Maybe add documents in the
weightsparameter ofTabNetPretrainer.fitto say a 1d ndarray with the same length as theX_train.Closing issues
closes #499
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).