Repository navigation
v0.1b hotfix: prevent Windows model-pack import crash - #19
Open
drdeepaksatheesh wants to merge 11 commits into
Open
drdeepaksatheesh wants to merge 11 commits into
drdeepaksatheesh wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
What changed
tauri::async_runtime::spawn_blockingso filesystem hashing/copying cannot block the UI thread;.importingdirectories when validation/copy fails;cargo test --libbefore packaging;.importing/disabled version directories, and tolerates unreadable entries instead of terminating the app;0.1.0-alpha.5.Windows reproduction evidence
Alpha.4 import appeared to complete, then the application repeatedly crashed. Renaming the app-data
modelsdirectory tomodels-disabledmade the application launch and remain stable. This isolates the remaining failure to installed-pack discovery rather than the PDF reader, sidecars, or general shell.CI evidence
GitHub Actions run
35044524005for alpha.5:Validated alpha.5 installer:
Open Document Understanding_0.1.0-alpha.5_x64-setup.exe767868411b45021f2455c61e77419d2918acd8018d621bb6797c4d01a796e632The PR remains open only for the targeted Windows smoke test: install alpha.5, rename
models-disabledback tomodels, launch the app, and confirm the existing fixture is discovered without a crash. If discovery fails, alpha.5 should surface an error rather than terminate.