Repository navigation
v0.1a.2: tolerate PDF spacing differences in reference lookup - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
The Windows smoke test showed that PDF.js can extract visually separated word runs as joined text (
a given->agiven). The v0.1a reference engine previously used exact normalized-text lookup and therefore rejected a supported passage.Fix
agivenextraction seen in the smoke test;0.1a.2and app package to0.1.0-alpha.2.This is deterministic normalization, not semantic/fuzzy matching: unknown content must still return
unsupported.CI evidence
GitHub Actions run
34926919222: PASS.agivenregression: PASSMerged after CI passed.