Preserve nested PostgreSQL function defaults - #1119
Open
yzxcj797 wants to merge 1 commit into
Open
Conversation
Recursively serialize function arguments and casts when converting PostgreSQL default expressions. This keeps nested functions such as the pg_dump default from issue drawdb-io#431 intact instead of dropping their arguments.
|
@yzxcj797 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing a PostgreSQL table with a default expression containing nested function calls discarded the arguments. For example, the issue's pg_dump default became:
The shared SQL AST serializer now recursively renders function arguments and PostgreSQL
::typecasts. PostgreSQL function defaults use that serializer instead of a one-level local conversion, preserving expressions such as:Fixes #431.
Testing
npm test— 1/1 regression test passesnpm run lint— passes with zero warningsnpm run build— passes (existing lottie-web eval and large-chunk warnings remain)npx prettier --checkon changed files — passesgit diff --check— passes