Fix MSSQL import of exported scripts - #1118
Open
yzxcj797 wants to merge 1 commit into
Open
Conversation
The transactsql grammar of node-sql-parser cannot parse ALTER TABLE ... ADD FOREIGN KEY statements and fails on semicolon-terminated statements followed by GO batch separators, which broke importing scripts exported by the MSSQL exporter. Parse GO batches as semicolon-separated statements and parse extracted foreign key definitions with the mysql grammar, which produces the alter statement shape fromMSSQL already handles. Add vitest and round-trip regression tests.
|
@yzxcj797 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scripts exported from the MSSQL generator could not be imported again. Two parser-boundary cases caused the failure:
GObatch separator;ALTER TABLE ... ADD FOREIGN KEY, which the current transactsql grammar innode-sql-parserdoes not support.MSSQL import now normalizes
GObatches into statement separators before parsing. Foreign-key ALTER statements are extracted, converted to the equivalent MySQL ALTER syntax accepted by the parser, and converted back into the AST shapefromMSSQLalready consumes. Named constraints, schema-qualified tables, quoted identifiers, composite column lists, referential actions, scripts without semicolons, and single-statement inputs are covered.Fixes #320.
Testing
npm test— 8/8 tests passnpm run lint— passes with zero warningsnpm run build— passes (existing lottie-web eval and large-chunk warnings remain)git diff --check— passesThe new tests cover exported-style table/FK round trips, GO with and without semicolons, named constraints,
ON UPDATE/ON DELETEactions, extended-propertyEXECbatches, no-GO input, single non-terminated statements, and multi-line foreign-key column lists.