Skip unsupported PostgreSQL views during import - #1116
Open
yzxcj797 wants to merge 1 commit into
Open
Conversation
Split PostgreSQL source with quote, comment, and dollar-quote awareness before parsing, then omit view declarations that the diagram model does not represent. This keeps multi-SELECT views from aborting import of the surrounding tables.
|
@yzxcj797 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL schema imports currently fail when a
CREATE VIEWstatement contains a secondSELECTafterUNION. The SQL parser rejects that view shape before the surrounding tables can be imported.The diagram model does not represent views, so this change adds a PostgreSQL-specific preprocessing pass that:
E''escapes, line comments, nested block comments, and dollar-quoted bodies;CREATE,CREATE OR REPLACE, temporary, and materialized view declarations;Testing
npm test— 4/4 tests passSELECTview removal and successful parser round tripnpm run lint— passes with zero warningsnpm run build— passes (existing lottie-web eval and large-chunk warnings remain)npx prettier --checkon the new files and package manifest — passesgit diff --check— passesFixes #432.