Skip to content

Propagate warning-test failures to the runner’s exit status - #63

Merged
MikeBusuttil merged 2 commits into
masterfrom
copilot/fix-warn-tests-misbehaving
Sep 18, 2026
Merged

MikeBusuttil merged 2 commits into
masterfrom
copilot/fix-warn-tests-misbehaving

Conversation

Copilot AI commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Missing warnings already fail the assertions, but the test runner discards the suite result and exits successfully, masking failures in CI.

  • Runner: Return a nonzero exit status when the suite reports failures or errors.
  • Regression coverage: Verify that all warning-test types reject missing warnings and that runner exit codes reflect successful, failed, and errored results.

Copilot AI linked an issue Sep 18, 2026 that may be closed by this pull request
Co-authored-by: MikeBusuttil <31480000+MikeBusuttil@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix warn tests to accurately detect warnings Propagate warning-test failures to the runner’s exit status Sep 18, 2026
Copilot AI requested a review from MikeBusuttil September 18, 2026 14:59

@MikeBusuttil MikeBusuttil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, hope it works

@MikeBusuttil
MikeBusuttil marked this pull request as ready for review September 18, 2026 18:35
@MikeBusuttil
MikeBusuttil merged commit b304c45 into master Sep 18, 2026
@MikeBusuttil
MikeBusuttil deleted the copilot/fix-warn-tests-misbehaving branch September 18, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn tests are misbehaving

2 participants