Support configurable rounding modes in sigfig.round - #61
Closed
MikeBusuttil with Copilot wants to merge 4 commits into
Closed
MikeBusuttil with Copilot wants to merge 4 commits into
MikeBusuttil with Copilot wants to merge 4 commits into
Conversation
Closed
Co-authored-by: MikeBusuttil <31480000+MikeBusuttil@users.noreply.github.com>
Co-authored-by: MikeBusuttil <31480000+MikeBusuttil@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to round down with rounding modes
Support configurable rounding modes in sigfig.round
Sep 18, 2026
MikeBusuttil
requested changes
Sep 18, 2026
Collaborator
There was a problem hiding this comment.
move all new test cases out of here and into test_equality.csv
Collaborator
|
resolved in #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sigfig.roundlacked directional rounding while preserving a specified number of significant figures. This adds amodekeyword supporting all eight decimal rounding modes.sigfig; applymodeto significant-figure, decimal-place, and uncertainty rounding. KeepROUND_HALF_UPas the default.ROUND_DOWN) from toward-negative-infinity rounding (ROUND_FLOOR).