Skip to content

ci(release): unblock the npm publish #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpezto merged 2 commits into from
Oct 14, 2026
Merged

ci(release): unblock the npm publish #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f032d6
ci(release): skip the windows-11-arm npm prebuild
dpezto Oct 14, 2026
998b711
ci(release): allow a manual npm publish of the current version
dpezto Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/package-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,12 @@ jobs:
runs-on: ${{matrix.os}}
strategy:
matrix:
# windows-11-arm is left out: node-gyp on that image fails to locate
# Visual Studio (ERR_CHILD_PROCESS_STDIO_MAXBUFFER in its finder), which
# cancelled the whole matrix and skipped the 4.2.0 and 4.2.1 publishes.
# Windows on ARM installs fall back to building from source.
os:
- windows-2022
- windows-11-arm
- ubuntu-24.04
- ubuntu-24.04-arm
- macos-15
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
on:
push:
branches: [main]
# Recovery path for a registry publish that failed after the release was cut.
# Runs from this file so npm's trusted publisher still matches.
workflow_dispatch:
inputs:
npm:
description: Publish the current version to npm
type: boolean
default: false

permissions:
contents: write
Expand All @@ -29,7 +37,7 @@
# still works, but the release PR won't get CI and needs an admin merge).
continue-on-error: true
with:
app-id: ${{ secrets.RELEASE_PLEASE_APP_ID }}

Check failure on line 40 in .github/workflows/release.yml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
avoid using deprecated input "app-id" in action "actions/create-github-app-token@v3": Use 'client-id' instead [action]

Raw Output:
e:.github/workflows/release.yml:40:11: avoid using deprecated input "app-id" in action "actions/create-github-app-token@v3": Use 'client-id' instead [action]
private-key: ${{ secrets.RELEASE_PLEASE_APP_KEY }}
- id: rp
uses: googleapis/release-please-action@45996ed1f6d02564a971a2fa1b5860e934307cf7 # v5
Expand All @@ -45,7 +53,7 @@
# the OIDC id-token.
npm:
needs: release-please
if: needs.release-please.outputs.release_created == 'true'
if: needs.release-please.outputs.release_created == 'true' || (github.event_name == 'workflow_dispatch' && inputs.npm)
permissions:
contents: read
id-token: write
Expand Down
Loading