Repository navigation
Conversation
fixes doy#156
pschmitt
added a commit
to pschmitt/rbw
that referenced
this pull request
Oct 7, 2026
Port of Frederik Schwan's upstream PR "implement fido 2fa" (doy#383, commit 2183b8e), adapted to this fork: - parse TwoFactorProviders2 and keep the WebAuthn (type 7) challenge on Error::TwoFactorRequired - new optional `fido2` cargo feature (Mozilla's `authenticator` crate); rbw-agent signs the challenge with a security key, prompting for the key's PIN via pinentry, and streams Response::Progress messages that the client prints while it waits for the final response - fork adaptations: per-account ui_url, the fork's pinentry cancel/timeout plumbing, the reworked interactive login flow - packaging: Nix package enables `fido2` (pkg-config + udev); CI and justfile musl builds stay on default features, Linux all-features jobs install libudev-dev; deny.toml skips authenticator's older crypto deps and ignores the serde_cbor unmaintained advisory The upstream PR's unrelated clippy-style cleanups were already in this fork or are left out. Co-authored-by: Frederik Schwan <frederik@tty42.de> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YTm1GQVoyjsteymHPCRW75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been tested against vaultwarden.
fixes #156