Repository navigation
Conversation
Client::add always sent type 1, so a secure note would have been created
as a login. The cipher type is now shared with edit, and secureNote is
sent as {"type": 0}.
pschmitt
added a commit
to pschmitt/rbw
that referenced
this pull request
Sep 25, 2026
Creates a secure note instead of a login (our take on upstream doy#381). The editor template switches to `data: {type: secure_note}` with an empty `notes` field; piped stdin is stored verbatim as the note instead of being parsed as YAML/JSON, and then requires NAME. Conflicts with USER, --uri and --generate (plus the pwgen flags implying it). Works with --from-file as well. The template construction and editor/parse flow that add_structured and add_from_file duplicated now live in new_entry_template/edit_new_entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Los96z27r146Vkgchu6qkb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rbw addcould only create logins. This adds--secure-note, which stores theeditor contents (or stdin) as the note of a new secure note. It conflicts with
the
userargument and--uri.Client::addalways senttype: 1, so any non-login entry would have beencreated as a login. The cipher type is now computed by a shared helper used by
both
addandedit, andsecureNoteis sent as{"type": 0}. The type isoptional when deserializing, so sync responses without it (or with null) still
parse.
Tested against a Vaultwarden server: the new entry shows up as a secure note in
the official Bitwarden app, and plain
rbw addstill creates logins as before.🤖 Generated with Claude Code