fix(android): normalize legacy ICY punctuation - #2674
Open
pke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
ExoPlayer's ICY decoder falls back to ISO-8859-1 when metadata is not valid UTF-8. Some real-world ICY streams send Windows-1252 punctuation, so bytes such as 0x92 reach React Native Track Player as U+0092 instead of the intended U+2019 apostrophe.
Testing
The regression tests exercise real ExoPlayer Metadata and IcyInfo objects, cover every defined Windows-1252 C1 mapping, and verify normalization occurs before artist/title splitting.