Implement CA1036: Add missing comparison operators to IComparable<T> types#11733
Open
Hualii wants to merge 1 commit into
Open
Implement CA1036: Add missing comparison operators to IComparable<T> types#11733Hualii wants to merge 1 commit into
Hualii wants to merge 1 commit into
Conversation
…types - GlyphLookupRecord: Add <, >, <=, >= operators - TextEffectBoundary: Add Equals, GetHashCode, and comparison operators - ValidatedPartUri: Add Equals, GetHashCode, and comparison operators - MemoryStreamBlock: Add Equals, GetHashCode, and comparison operators Fixes dotnet#10271
Author
|
@dotnet-policy-service agree
***@***.***
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #10271 by implementing CA1036 (Override methods on comparable types) for the following types:
<,>,<=,>=operatorsEquals,GetHashCode, and comparison operatorsEquals,GetHashCode, and comparison operatorsEquals,GetHashCode, and comparison operatorsAll implementations follow the CA1036 rule requirements:
Equals(object)andGetHashCode()==,!=,<,>,<=,>=operatorsFixes #10271
Microsoft Reviewers: Open in CodeFlow