Skip to content

Expose Composite ML-DSA CNG identifiers - #132353

Open
PranavSenthilnathan wants to merge 1 commit into
dotnet:mainfrom
PranavSenthilnathan:pranavsenthilnathan-composite-mldsa-cng-apis
Open

Expose Composite ML-DSA CNG identifiers#132353
PranavSenthilnathan wants to merge 1 commit into
dotnet:mainfrom
PranavSenthilnathan:pranavsenthilnathan-composite-mldsa-cng-apis

Conversation

@PranavSenthilnathan

Copy link
Copy Markdown
Member

Fixes #130052

Note

This PR description was generated with GitHub Copilot.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5676db47-d54b-4946-97ec-7fc0a7392c30
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes Composite ML-DSA identifiers for Windows CNG by promoting existing internal constants to public CngAlgorithm / CngAlgorithmGroup properties, marked as experimental to align with the PQC API posture.

Changes:

  • Make CngAlgorithm.CompositeMLDsa and CngAlgorithmGroup.CompositeMLDsa public and annotate them with Experimental(SYSLIB5006).
  • Update the System.Security.Cryptography reference assembly to include the new public properties.
  • Remove the test-only CngAlgorithm extension shim now that the identifiers are available publicly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs Exposes CompositeMLDsa as a public experimental algorithm identifier.
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithmGroup.cs Exposes CompositeMLDsa as a public experimental algorithm-group identifier.
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs Adds the new public properties to the ref contract with Experimental("SYSLIB5006").
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestHelpers.Cng.cs Removes the internal test-only extension helper; tests now use the public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add CompositeMLDsa property to CngAlgorithm and CngAlgorithmGroup

3 participants