Skip GitHub_130545 on NativeAOT - #132342
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f7cffaf-a483-4932-9813-1fb349883986
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Skips the GitHub_130545 regression test specifically on NativeAOT, where the test’s reflection-based generic-constraint resolution currently fails with TypeLoadException, while preserving coverage on CoreCLR and Mono.
Changes:
- Add a conditional
[ActiveIssue]skip on the failing test method whenTestLibrary.Utilities.IsNativeAotis true. - Reference
TestLibraryfrom the test project soUtilities.IsNativeAotcan be used for the runtime-detection condition.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Loader/classloader/StaticVirtualMethods/Regression/GitHub_130545.csproj | Adds TestLibrary project reference to enable runtime detection via Utilities.IsNativeAot. |
| src/tests/Loader/classloader/StaticVirtualMethods/Regression/GitHub_130545.cs | Applies ActiveIssue conditional skip for NativeAOT only on the failing regression test. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
jkoritzinsky
approved these changes
Aug 14, 2026
jkotas
approved these changes
Aug 14, 2026
Member
|
/ba-g build analysis misclassifying failures dotnet/arcade#17340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks #132030
The
GitHub_130545regression test was added for Mono WASM AOT and relies on reflection to force the gsharedvt path. The exact reflected method and generic argument are statically known, but NativeAOT currently fails while resolving the generic constraint metadata withTypeLoadException.Temporarily skip this test only under NativeAOT while preserving its CoreCLR and Mono coverage. The test project now references
TestLibraryfor the runtime detection condition. Issue #132030 remains open to track the underlying NativeAOT reflection-metadata bug.Validation:
src/tests/build.sh -Test Loader/classloader/StaticVirtualMethods/Regression/GitHub_130545.csproj x64 ReleaseNote
This PR description was generated with GitHub Copilot.