Match versioned OS platform attributes in CoreCLR PInvokeCollector, add regression test - #132332
Open
akoeplinger with Copilot wants to merge 2 commits into
Open
Match versioned OS platform attributes in CoreCLR PInvokeCollector, add regression test#132332akoeplinger with Copilot wants to merge 2 commits into
akoeplinger with Copilot wants to merge 2 commits into
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
…ession test Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CoreCLR collector to match versioned OS platform attributes
Match versioned OS platform attributes in CoreCLR PInvokeCollector, add regression test
Aug 14, 2026
pavelsavara
approved these changes
Aug 14, 2026
akoeplinger
marked this pull request as ready for review
August 14, 2026 18:58
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #132300: the CoreCLR generator's platform-attribute filter still compared
SupportedOSPlatform/UnsupportedOSPlatformstrings to_targetOSwith exact equality, so versioned attributes like[SupportedOSPlatform("browser1.0")]were treated as non-matching on that path (mono's collector was already fixed).CoreCLR collector fix
MatchesTargetOShelper (with theNETFRAMEWORKconditional fornet472) intosrc/tasks/WasmAppBuilder/coreclr/PInvokeCollector.cs, per maintainer preference to keep the collectors independent rather than share code.EvaluatePlatformAttributesnow callsMatchesTargetOSinstead of exact string comparison for both attributes.src/tasks/WasmAppBuilder/mono/PInvokeCollector.csis unchanged.Regression test
VersionedOSPlatformPInvokeIsIncludedtoPInvokeTableGeneratorTestsinsrc/mono/wasm/Wasm.Build.Tests.[SupportedOSPlatform("browser1.0")](must matchTargetOS=browser) alongside one annotated[SupportedOSPlatform("windows1.0")](must not match).