Skip to content

Remove SQL scripts from AdoNet NuGet packages - #6049

Merged
ReubenBond merged 1 commit into
dotnet:masterfrom
sergeybykov:remove-sql-scripts
Oct 16, 2019
Merged

Remove SQL scripts from AdoNet NuGet packages#6049
ReubenBond merged 1 commit into
dotnet:masterfrom
sergeybykov:remove-sql-scripts

Conversation

@sergeybykov

Copy link
Copy Markdown
Contributor

Based on the discussion in #4867, this PR is a replacement for #6044. It removes SQL scripts from the AdoNet provider packages. The prevailing opinion is that we shouldn't have them pollute the AdoNet packages, and that we don't even want a readme.md there.

We can separately decide how to let developers know where to find the scripts.

@siennathesane

siennathesane commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

Has this been captured in the docs? I can update the docs if someone can point me in the right direction.

@sheng-jie

Copy link
Copy Markdown

After remove the folder, it's not easy to find the script files even follow the Configuring ADO.NET Providers and ADO.NET Grain Persistence.

So the docs should be updated and be clearly.

@siennathesane

Copy link
Copy Markdown
Contributor

@sergeybykov any thoughts?

@sergeybykov

Copy link
Copy Markdown
Contributor Author

Please help me understand where the problem is.

ADO.NET Grain Persistence points to ADO.NET Database Configuration as requirement #3 at the top of the page.

ADO.NET Database Configuration list all the scripts in the tables.

Is that these links to individual script files don't make it obvious that one needs to download and run them?

@sergeybykov
sergeybykov deleted the remove-sql-scripts branch November 8, 2019 16:59
@sheng-jie

Copy link
Copy Markdown

@sergeybykov The doc doesn't describe where to find the script for creating OrleansQuery Table.

@sergeybykov

Copy link
Copy Markdown
Contributor Author

I submitted #6118 that hopefully addresses this.

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants