Reminders: Improve error message when using reminders without a reminder table - #4287
Merged
Merged
Conversation
…uring a reminder table
jason-bragg
approved these changes
Mar 22, 2018
jason-bragg
left a comment
jason-bragg
left a comment
Contributor
There was a problem hiding this comment.
LG2M, though I've a minor concern regarding the logging message. Approve, even if the suggested logging change is not taken.
| internal class ReminderRegistry : GrainServiceClient<IReminderService>, IReminderRegistry | ||
| { | ||
| private const string ReminderServiceNotConfigured = | ||
| "The reminder service has not been configured. Reminders can be configured using extension methods from the following packages:" |
Contributor
There was a problem hiding this comment.
Not convinced we should be listing all of these in code.
No good way to keep this list accurate.
A reference to docs should be sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative implementation of #4280
Fixes #4278