CreateOrleansTables_SqlServer.sql: Removed support for SQL Server 2000 and 2005 - #1779
Conversation
|
I'm OK for removing the SQL Server 2005 specific bits, but I would like to maintain the view as I'd like to dump that information when starting up. I have at least two things to help in trouble shooting:
These could help in trouble-shooting. I'm not adamant on having the view though, up for discussion. |
|
@veikkoeeva, what do you mean by "Dump data in the beginning", which data ? |
|
@veikkoeeva, we can get the server version with ADO.NET ServerVersion. |
|
@shayhatsor Or using the DbConnection version of it. I'm not sure if this will work for all DBs, but I'm inclined to say this is better than the view. Dump some data on database, such as its version, about the queries (as discussed elsewhere). Server version could be handy, say, when thinking on how the query engine optimizes things. It's possible to ask, though, and reintroduce informational view if needed later. With this discussion, I'm OK with the removal. We can add |
|
I can't see people needing to move to Orleans and still having to support a sql server version over 8 years old. I think it's very reasonable to ask for 2012+ for minimum. |
|
This PR is about removing the code which was tailored for SQL 2000 & 2005. |
|
Thank you, @shayhatsor! |
Following @sergeybykov's comment. Also, it seems DateTime2 is supported from SQL Server 2008 and above, but Microsoft has stopped support for SQL Server 2005. So this PR is for removing support for SQL Server 2005 too.