Skip to content

CreateOrleansTables_SqlServer.sql: Removed support for SQL Server 2000 and 2005 - #1779

Merged
sergeybykov merged 1 commit into
dotnet:masterfrom
shayhatsor:master
May 23, 2016
Merged

CreateOrleansTables_SqlServer.sql: Removed support for SQL Server 2000 and 2005#1779
sergeybykov merged 1 commit into
dotnet:masterfrom
shayhatsor:master

Conversation

@shayhatsor

@shayhatsor shayhatsor commented May 21, 2016

Copy link
Copy Markdown
Member

Following @sergeybykov's comment. Also, it seems DateTime2 is supported from SQL Server 2008 and above, but Microsoft has stopped support for SQL Server 2005. So this PR is for removing support for SQL Server 2005 too.

@shayhatsor shayhatsor changed the title CreateOrleansTables_SqlServer.sql: Remove support for SQL Server 2000 CreateOrleansTables_SqlServer.sql: Removed support for SQL Server 2000 and 2005 May 21, 2016
@veikkoeeva

Copy link
Copy Markdown
Contributor

I'm OK for removing the SQL Server 2005 specific bits, but I would like to maintain the view as I'd like to dump that information when starting up. I have at least two things to help in trouble shooting:

  • Dump data in the beginning
  • Dump queries pretty-printed with parameters in Verbose3 (maybe add via a general interceptor)

These could help in trouble-shooting. I'm not adamant on having the view though, up for discussion.

@shayhatsor

Copy link
Copy Markdown
Member Author

@veikkoeeva, what do you mean by "Dump data in the beginning", which data ?
About the queries dump, I agree that could be useful.
About the view, I'd rather we remove it. With this PR, we won't have any version specific code. And for trouble-shooting, I don't think that the server version would be helpful in our scenarios.

@shayhatsor

Copy link
Copy Markdown
Member Author

@veikkoeeva, we can get the server version with ADO.NET ServerVersion.

@veikkoeeva

Copy link
Copy Markdown
Contributor

@shayhatsor Or using the DbConnection version of it. I'm not sure if this will work for all DBs, but I'm inclined to say this is better than the view.

Dump some data on database, such as its version, about the queries (as discussed elsewhere). Server version could be handy, say, when thinking on how the query engine optimizes things. It's possible to ask, though, and reintroduce informational view if needed later.

With this discussion, I'm OK with the removal. We can add ServerVersion sometime later too. @amccool?

@amccool

amccool commented May 22, 2016

Copy link
Copy Markdown
Contributor

I can't see people needing to move to Orleans and still having to support a sql server version over 8 years old. I think it's very reasonable to ask for 2012+ for minimum.

@shayhatsor

Copy link
Copy Markdown
Member Author

This PR is about removing the code which was tailored for SQL 2000 & 2005.
I believe we are in agreement about that, @sergeybykov please merge.

@sergeybykov
sergeybykov merged commit 12cf22c into dotnet:master May 23, 2016
@sergeybykov

Copy link
Copy Markdown
Contributor

Thank you, @shayhatsor!

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants