fix(reminders): enforce lifecycle provider consistency - #10908
Open
ReubenBond wants to merge 3 commits into
Open
fix(reminders): enforce lifecycle provider consistency#10908ReubenBond wants to merge 3 commits into
ReubenBond wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Lite
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs — The retry policy’s describe callback only reports "ETag mismatch"/"removed", so if this cleanup… |
|
src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs — The assertion compares StartAt at whole-second precision (NormalizeStartAt(...)), but the… |
What changed in this PR
Updates the Orleans reminders TestKit lifecycle conformance runner to align timestamp/schedule assertions with providers which persist whole-second precision and may exhibit bounded read/delete visibility convergence (eg, DynamoDB), while keeping strict ETag semantics.
Changes:
- Normalize lifecycle schedules and persisted
StartAtcomparisons to whole-second precision. - Apply the existing
ReminderTableRetryPolicybounded convergence behavior to point reads and deletion visibility checks. - Make cleanup removal resilient to ETag churn by retrying removals using the latest observed ETag.
| File | Description |
|---|---|
| src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs | Normalizes schedule assertions to whole-second precision and applies bounded convergence retries for reads/removals in lifecycle conformance scenarios. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs — RemovePersistedRowAsync uses row.ETag! when attempting cleanup removal. If a provider returns a… |
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
|
src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs — The assertion compares StartAt at whole-second precision (NormalizeStartAt(...)), but the… View resolved comment |
|
src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs — The retry policy’s describe callback only reports "ETag mismatch"/"removed", so if this cleanup… View resolved comment |
ReubenBond
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Lite
Findings: None
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs — RemovePersistedRowAsync uses row.ETag! when attempting cleanup removal. If a provider returns a… View resolved comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The lifecycle scenarios introduced in #10896 used half-second schedules even though the shared reminder-table contract guarantees whole-second timestamp precision. Their assertions also described provider visibility as eventually consistent, while lifecycle point reads are required to expose completed writes immediately; DynamoDB
ReadRowalready usesConsistentRead = true.Solution
Use whole-second lifecycle schedules and compare timestamps at the common provider precision. Lifecycle point reads, updates, and removals now fail immediately when completed writes are absent, ETags are empty, or an update reuses its prior ETag. Failure diagnostics report the exact row, schedule, and ETags.
Rationale
The conformance suite now expresses one consistent guarantee across providers: completed lifecycle mutations are immediately visible through point reads, schedules preserve the supported precision, and ETags identify each persisted version. MySQL and DynamoDB execute the same assertions without provider-specific delays or retries.
Follow-up to #10896