Update reviewer skill: never request changes, always use COMMENT#25747
Open
rolfbjarne wants to merge 2 commits into
Open
Update reviewer skill: never request changes, always use COMMENT#25747rolfbjarne wants to merge 2 commits into
rolfbjarne wants to merge 2 commits into
Conversation
Remove REQUEST_CHANGES from allowed review events and update instructions in both the workflow file and SKILL.md to always submit COMMENT reviews. The supersede-older-reviews setting was already enabled to hide previous review comments as outdated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the macios reviewer agent configuration and documentation to always submit GitHub PR reviews as COMMENT, removing REQUEST_CHANGES from the allowed review event types. This aligns the workflow behavior with the already-enabled supersede-older-reviews setting so prior reviews are superseded without using “Changes requested”.
Changes:
- Restrict the reviewer workflow’s allowed review events to
COMMENTonly. - Update reviewer instructions in the workflow markdown and SKILL.md to explicitly “always use COMMENT”.
- Regenerate the compiled
.lock.ymlworkflow to reflect the updated safe-outputs configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/macios-reviewer.md | Removes REQUEST_CHANGES from allowed review events and updates instruction text to always submit COMMENT. |
| .github/workflows/macios-reviewer.lock.yml | Regenerated lock workflow to enforce COMMENT-only in safe-outputs config/handler. |
| .github/skills/macios-reviewer/SKILL.md | Updates skill guidance to always submit COMMENT (never REQUEST_CHANGES or APPROVE). |
Comment on lines
+497
to
+499
| cat > "${RUNNER_TEMP}/gh-aw/safeoutputs/config.json" << 'GH_AW_SAFE_OUTPUTS_CONFIG_5d90b3a923aee92f_EOF' | ||
| {"create_pull_request_review_comment":{"max":50,"side":"RIGHT"},"create_report_incomplete_issue":{},"missing_data":{},"missing_tool":{},"noop":{"max":1,"report-as-issue":"true"},"report_incomplete":{},"submit_pull_request_review":{"allowed_events":["COMMENT"],"max":1,"supersede_older_reviews":true}} | ||
| GH_AW_SAFE_OUTPUTS_CONFIG_5d90b3a923aee92f_EOF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove REQUEST_CHANGES from allowed review events and update instructions in
both the workflow file and SKILL.md to always submit COMMENT reviews. The
supersede-older-reviews setting was already enabled to hide previous review
comments as outdated.
🤖 Pull request created by Copilot