Skip to content

[net11.0] [dotnet] Remove workaround for dotnet/sdk#52480#25720

Draft
rolfbjarne wants to merge 2 commits into
net11.0from
rolfbjarne/dev-rolf-remove-sdk-52480-workaround
Draft

[net11.0] [dotnet] Remove workaround for dotnet/sdk#52480#25720
rolfbjarne wants to merge 2 commits into
net11.0from
rolfbjarne/dev-rolf-remove-sdk-52480-workaround

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

The _LinkReadyToRunMachO target override was added as a temporary workaround to skip the built-in dylib creation until dotnet/sdk#52480 was merged.

That PR has now been merged, so the workaround is no longer needed.

🤖 Pull request created by Copilot

The workaround overrode the _LinkReadyToRunMachO target to skip
the built-in dylib creation. Now that dotnet/sdk#52480 has been
merged, this is no longer needed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rolfbjarne rolfbjarne changed the base branch from main to net11.0 June 17, 2026 17:10
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #889bbd6] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 889bbd684df4a0e7f05ddf4305c53485e693b57f [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #889bbd6] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 889bbd684df4a0e7f05ddf4305c53485e693b57f [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build #889bbd6] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 889bbd684df4a0e7f05ddf4305c53485e693b57f [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Error: The system requirements for the hash to compare against (d43652b�(B) are different than for the current hash. Comparison is currently not supported in this scenario.�(B

Pipeline on Agent
Hash: 889bbd684df4a0e7f05ddf4305c53485e693b57f [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #889bbd6] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 205 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 9 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 26 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 30 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 23 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 26 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 889bbd684df4a0e7f05ddf4305c53485e693b57f [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants