[Kameda] Add K2DPicture class implementation - #54
Open
joakim-d wants to merge 1 commit into
Open
Conversation
joakim-d
changed the title
Report for MarioClub_us (06ef8fc - 9c95db1)📈 Matched code: 46.11% (+0.06%, +2048 bytes) ✅ 6 new matches
|
joakim-d
force-pushed
the
reverse_k2dpicture
branch
from
August 2, 2026 16:15
a338e9f to
a58825e
Compare
joakim-d
marked this pull request as ready for review
August 2, 2026 16:17
joakim-d
changed the title
SwareJonge
reviewed
Aug 2, 2026
Comment on lines
+172
to
+174
| } else { | ||
| if (!useBlackAndWhite) | ||
| { |
Collaborator
There was a problem hiding this comment.
no need for a separate else scope here
Contributor
Author
There was a problem hiding this comment.
Do you mean that I should change the branching like so ?
if (!useColorBlend) {
if (!useBlackAndWhite) {
} else {
}
} else if (!useBlackAndWhite) {
} else {
}
Contributor
Author
There was a problem hiding this comment.
I changed this bit, I hope it's what you meant :)
joakim-d
force-pushed
the
reverse_k2dpicture
branch
from
August 2, 2026 20:57
a58825e to
9c95db1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add K2DPicture class implementation