refactor(publishing): delete 16 flat back-compat shims + retire-when-zero-consumers policy (DEPRECATION-SHIM-POLICY-1) - #96
Merged
Conversation
… consumers, document retire-when-zero-consumers policy (DEPRECATION-SHIM-POLICY-1)
… provenance re-stamp; repoint deleted-shim doc references to transmission/metadata homes
…mission package init so module-ref guard resolves nested refs (DOC-MODREF-1)
…dule manuscript (imports newly require it via DOC-MODREF-1 init)
…st (top-level package descriptor gate)
…h subpackages; mirror tests; repoint scripts + docs (SUBMODULAR-SEARCH-1)
…, nested layer-contract paths, test-cluster doc pairs (SUBMODULAR-SEARCH-1)
…after split (SUBMODULAR-SEARCH-1)
…pshot row + re-stamp (SUBMODULAR-SEARCH-1)
…s formatter (SUBMODULAR-SEARCH-1)
…s post-split (SUBMODULAR-SEARCH-1)
… subpackage (SUBMODULAR-SEARCH-1)
…promotion to Layer 1 (DOC-MODREF-1 follow-through)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Completes
DEPRECATION-SHIM-POLICY-1(Medium): retires the flat back-compat shim layer ininfrastructure/publishing/and documents the standing policy.repository_metadata.pywas uncounted): 11 metadata/release (metadata_export,metadata_export_cli,metadata_from_config,metadata_package,metadata_stage,repository_metadata,release_cli,release_pairing,release_receipts,release_workflow,release_workflow_zenodo) + 5 transmission (transmission_barcode_strip,transmission_bookends,transmission_figure,transmission_models,transmission_page_check). Historical import paths now fail fast withModuleNotFoundError— clean cutover, no stubs.infrastructure/publishing/metadata/metadata_export_cli.py(import re-pointed atinfrastructure.publishing.metadata.metadata_export) andinfrastructure/publishing/arxiv/README.md(runnable snippet re-pointed atinfrastructure.publishing.metadata.metadata_from_config). The row's other two "consumers" (tests/infra_tests/publishing/test_pypi.py,scripts/publish/test_pypi.py) import through the retainedpypi_releasesurface — implementation home, not a shim — so they stay (row discrepancy documented in the policy section).INTENTIONAL_SUBPROCESS_POLICIESrelease-rerendercited the deleted flatrelease_workflow.py; re-pointed atinfrastructure/publishing/release/release_workflow.py(inventory binding test passes).infrastructure/publishing/AGENTS.md: retire-when-zero-consumers for the three retained surfaces (platforms.py,api.pyre-export surfaces;pypi_release.pyimplementation home), the zero-consumer proof command, and theBackwards-compat shimdocstring ban.Verification
uv run pytest tests/infra_tests/publishing/ -q→ 869 passed (was 1 failed mid-change: the orphaned subprocess-policy source binding; fixed and re-proven).grep -rn "Backwards-compat shim" infrastructure/publishing/ --include='*.py' --include='*.md'→ 0 hits (stale.pycartifacts were the only residue; cleared).infrastructure/ tests/ scripts/for the deleted module paths (excluding their new homes) → 0 hits.uv run python scripts/docgen/counts.py --refresh-coverage-provenance --write→ generator-owned provenance refreshed for the new file inventory.Compatibility and failure boundaries
source_pathstring.Review checklist