Skip to content

Add validate tests#639

Open
alinaliBQ wants to merge 15 commits into
documentdb:mainfrom
alinaliBQ:validate
Open

Add validate tests#639
alinaliBQ wants to merge 15 commits into
documentdb:mainfrom
alinaliBQ:validate

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Add command operator tests for validate. Tests database validate behavior, output collection, syntax, and errors.
Adds setup field in DiagnosticTestCase.

@alinaliBQ alinaliBQ marked this pull request as ready for review June 23, 2026 18:13
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 23, 2026 18:13
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 23, 2026
@documentdb-triage-tool

documentdb-triage-tool Bot commented Jun 23, 2026

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status Needs Review
Confidence: 0.82 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (2087+1 LOC, 12 files); LLM: Adds new validate command tests and extends DiagnosticTestCase with a setup field, expanding test coverage for a specific MongoDB command.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

eerxuan
eerxuan reviewed Jun 25, 2026
View reviewed changes
Comment thread ...compatibility/tests/system/diagnostic/commands/validate/test_validate_bool_param_coercion.py
Comment thread .../compatibility/tests/system/diagnostic/commands/validate/test_validate_response_structure.py Outdated
alinaliBQ added 12 commits June 25, 2026 11:31
@alinaliBQ
inital generated tests
f122485 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
update with style guide
e345708 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
remove duplicates and formats
01c02a4 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
change according to review guide
deba234 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add setup field
7c68964 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
split files
7de16e5 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add missing tests
823bc5b 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
remove exact duplicates
ac37999 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
rename tests
ec3203f 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
merge identical test functions
332eb7e 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
fix PR
058d49b 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
put success together
0604735 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ added 3 commits June 25, 2026 11:45
@alinaliBQ
remove near-identical BSON cases
d2322a8 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add validate_repair and skip on tests that fail on replica_set
2cd3cf6 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add helper bind_collection
f7e4015 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
alinaliBQ commented Jun 25, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments. also added validate_repair capability to skip on validate tests that only work on standalone instances

Comment thread ...compatibility/tests/system/diagnostic/commands/validate/test_validate_bool_param_coercion.py
Comment thread .../compatibility/tests/system/diagnostic/commands/validate/test_validate_response_structure.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerxuan eerxuan eerxuan approved these changes

Assignees

No one assigned

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alinaliBQ @eerxuan