Extract core logic

[Kikobeats]

Currently in this repository have logic very closed with docpress. For example, the logic related about determinate the JS/CSS files to load need to moved in core in favour to make more easy create different docpress themes.

[rstacruz]

Makes sense. Any candidates for logic to be extracted aside from that?

On Sat, Aug 27, 2016, 12:32 AM Kiko Beats notifications@github.com wrote:

Currently in this repository have logic very closed with docpress. For
example, the logic related about determinate the JS/CSS files to load need
to moved in core in favour to make more easy create different docpress
themes.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#134, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikTHOHlf3tQGxIlyhVWSdde45TEinks5qjv6OgaJpZM4JuKUL
.

[Kikobeats]

google analytics should be a docpress plugin or docpress-core

[rstacruz]

Hmmm.

Google Analytics needs to inject a JS snippet somewhere. Two ways I can think about how this can go:

• put a plugin before docpress-base and insert it into ms.metadata().scripts
• put a plugin after docpress-base and inject that script snippet

Indeed, the scripts / styles logic can be in docpress-core.

[Kikobeats]

I think that the first point will be a good approach for make easy create other plugins, putting the share content inside meta

[rstacruz]

I think that is best to do with injections. Like:

file.content = file.content.replace('', '...')

On Mon, Aug 29, 2016, 4:47 PM Kiko Beats notifications@github.com wrote:

I think that the first point will be a good approach for make easy create
other plugins, putting the share content inside meta

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#134 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikajed_hPXtF0gFTtewkf0gaxT6dKks5qkpyvgaJpZM4JuKUL
.