Repository navigation
Conversation
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
vagenas
reviewed
Oct 30, 2026
vagenas
left a comment
vagenas
left a comment
Member
There was a problem hiding this comment.
@lehors thanks for the proposal. A couple of points on this:
- apparently only headings restart the numbering, so two separate numbered lists in the same section would still number as one; we'd best employ a more general rule
- this seems to rely on python-docx internals (
numbering_definitions._numbering); we should best stick to public APIs
…ntent breaks them Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Contributor
Author
|
@vagenas this new version restarts ordered lists at 1 whenever something other than list content breaks them. I also dropped the numbering_definitions._numbering call in favor of public APIs. |
lehors
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes issue #224.