Fix incorrect new-owner prerequisite in ownership transfer - #2099
Merged
Conversation
Pemacaa
approved these changes
Aug 24, 2026
Co-authored-by: Carla Marmolejos <110252982+Pemacaa@users.noreply.github.com> Signed-off-by: Stephanie Coulter <stephanie.coulter@dnsimple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer flagged that the "Before you start" section of Transfer Account Ownership told them the new owner "must have (or create) their own DNSimple user." That is backwards, and following it walks straight into an error.
Ownership is transferred by changing the user email on the account owner.
UserChangeEmailInteractorrejects the change if any user identity already exists for the target email, returning "Email has already been taken" (interactor.message_error_user_emailtaken).Useralso validates email uniqueness. So the new owner must not already have a DNSimple user at that address.Changes:
No cross-link changes needed. The two articles that link here describe it accurately.