Stop relying on label to decide the file is VTT - #66
Open
JackLewis-digirati wants to merge 1 commit into
Open
JackLewis-digirati wants to merge 1 commit into
JackLewis-digirati wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Previously,
labelwas used to figure out if the file was in the VTT format, along with checking for various strings in it. This caused issues as it would decide this label is VTT:This tightens up that validation to only rely on
profileandlabel, as well as remove some redundant checks ontext/vtt, as it already checks these same fields forvtt