Update to dotnet10 - #652
Merged
Merged
Conversation
JackLewis-digirati
approved these changes
Aug 21, 2026
Minimal changes, same functionality.
* Remove unused method/classes * Remove unused using * Resolve some unused usings * Introduce some extension blocks to tidy helper classes * Remove obsolete props
This reverts commit 048384f.
These are both identical images but the former is self documenting and consistent with other projects in org
* Set checksum override for SQS clients using localstack. I don't think this is ever actually exercised but would cause issues if project was run against localstack locally. * Change nullability of s3 headers in our mapped object to map downstream * Remove now defunct xml header
Change in behaviour for 3->4, it will now return null, whereas previously it would return a empty
donaldgray
force-pushed
the
feature/dotnet10
branch
from
August 21, 2026 15:56
1146d5a to
2dbd39a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrade to dotnet10, resolves #647
nullnow, rather than empty collections so added handling for those.JSType.Error.Title, rather than our ownError.Title).PresentationController.HandleDelete()andDeleteEntityResult)LocalStackFixturehealth check, without this the image could report as ready before some of the svcs (e.g. s3) was readyConfiguration Changes
Note
This PR introduces configuration changes.
MEDIATR_LICENSE_KEYorLUCKYPENNY_LICENSE_KEYnullMediatr is now on 13+, which requires a license. To avoid baking into container image we can provide via envvars, see https://github.com/LuckyPennySoftware/MediatR#setting-the-license-key for details.