Fix range check

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solarity/zkit",
-  "version": "0.3.7",
+  "version": "0.3.8",
   "license": "MIT",
   "author": "Distributed Lab",
   "readme": "README.md",

src/core/templates/verifier_groth16.sol.ejs

@@ -140,7 +140,7 @@ contract <%=verifier_id%> {
             <% } -%>
 
             /// @dev check pairings
-            if not(iszero(verified_)) {
+            if verified_ {
                 verified_ := checkPairing(pointA_, pointB_, pointC_, publicSignals_, pointer_)
             }
         }

src/core/templates/verifier_plonk.sol.ejs

@@ -761,7 +761,7 @@ contract <%=verifier_id%> {
             verified_ := checkInput(proofArr_)
 
             /// @dev check pairings
-            if not(iszero(verified_)) {
+            if verified_ {
                 calculateChallenges(pointer_, proofArr_, publicSignals_)
                 calculateLagrange(pointer_)
                 calculatePI(pointer_, publicSignals_)

test/CircuitZKit.test.ts

@@ -69,6 +69,8 @@ export interface ShortTestPlonkVerifierType {
 }
 
 describe("CircuitZKit", () => {
+  const SCALAR_FIELD_SIZE = 21888242871839275222246405745257275088548364400416034343698204186575808495617n;
+
   function getArtifactsFullPath(circuitDirSourceName: string): string {
     return path.join(process.cwd(), "zkit", "artifacts", circuitDirSourceName);
   }
@@ -310,6 +312,41 @@ describe("CircuitZKit", () => {
         .to.be.true;
     });
 
+    it("should correctly create Solidity verifier and not verify invalid 'groth16' proof", async function () {
+      const circuitName = "Multiplier";
+      const verifierDirPath = getVerifiersDirFullPath();
+      const artifactsDirFullPath = getArtifactsFullPath(`${circuitName}.circom`);
+
+      const multiplierCircuit = getCircuitZKit<"groth16">(circuitName, "groth16", {
+        circuitName,
+        circuitArtifactsPath: artifactsDirFullPath,
+        verifierDirPath,
+      });
+
+      const expectedVerifierFilePath = path.join(verifierDirPath, `${multiplierCircuit.getVerifierName()}.sol`);
+
+      await multiplierCircuit.createVerifier("sol");
+      expect(fs.existsSync(expectedVerifierFilePath)).to.be.true;
+
+      await this.hre.run("compile", { quiet: true, force: true });
+
+      const proof = await multiplierCircuit.generateProof({
+        a: 10,
+        b: 20,
+      });
+
+      proof.publicSignals[0] = (BigInt(proof.publicSignals[0]) + SCALAR_FIELD_SIZE).toString();
+
+      const data = await multiplierCircuit.generateCalldata(proof);
+
+      const MultiplierVerifierFactory = await this.hre.ethers.getContractFactory("MultiplierGroth16Verifier");
+
+      const verifier = await MultiplierVerifierFactory.deploy();
+
+      expect(await verifier.verifyProof(data.proofPoints.a, data.proofPoints.b, data.proofPoints.c, data.publicSignals))
+        .to.be.false;
+    });
+
     it("should correctly create Solidity verifier and verify 'plonk' proof", async function () {
       const circuitName = "Multiplier";
       const verifierDirPath = getVerifiersDirFullPath();
@@ -344,6 +381,40 @@ describe("CircuitZKit", () => {
       expect(await verifier.verifyProof(data.proofPoints.proofData, data.publicSignals)).to.be.true;
     });
 
+    it("should correctly create Solidity verifier and not verify invalid 'plonk' proof", async function () {
+      const circuitName = "Multiplier";
+      const verifierDirPath = getVerifiersDirFullPath();
+      const artifactsDirFullPath = getArtifactsFullPath(`${circuitName}.circom`);
+
+      const multiplierCircuit = getCircuitZKit<"plonk">(circuitName, "plonk", {
+        circuitName,
+        circuitArtifactsPath: artifactsDirFullPath,
+        verifierDirPath,
+      });
+
+      const expectedVerifierFilePath = path.join(verifierDirPath, `${multiplierCircuit.getVerifierName()}.sol`);
+
+      await multiplierCircuit.createVerifier("sol");
+      expect(fs.existsSync(expectedVerifierFilePath)).to.be.true;
+
+      await this.hre.run("compile", { quiet: true });
+
+      const proof = await multiplierCircuit.generateProof({
+        a: 10,
+        b: 20,
+      });
+
+      proof.publicSignals[0] = (BigInt(proof.publicSignals[0]) + SCALAR_FIELD_SIZE).toString();
+
+      const data = await multiplierCircuit.generateCalldata(proof);
+
+      const MultiplierVerifierFactory = await this.hre.ethers.getContractFactory("MultiplierPlonkVerifier");
+
+      const verifier = await MultiplierVerifierFactory.deploy();
+
+      expect(await verifier.verifyProof(data.proofPoints.proofData, data.publicSignals)).to.be.false;
+    });
+
     it("should correctly create Vyper verifier and verify 'groth16' proof", async function () {
       const circuitName = "Multiplier";
       const verifierDirPath = getVerifiersDirFullPath();